-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finally add changelog for v0.3.11 #2248
Conversation
License: MIT Signed-off-by: Jeromy <[email protected]>
@RichardLitt wanna help me look this over? |
|
||
* BugFixes | ||
* Fix path parsing for add command (@djdv) | ||
* namesys: Make paths with multiple segemnts work. Fixes #2059 (@Kubuxu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/segemnts/segments/
License: MIT Signed-off-by: Richard Littauer <[email protected]>
Fixed. LGTM now. |
@RichardLitt if you look at the past commits in CHANGELOG.md, not all of them are capitalized. The option is either to keep it consistent with the commit messages, or fix it once for all. |
There is no note about the webui update |
@rht I don't think we have to make a hard & fast rule here about that. There was at least a spelling error in one of the commits which needed to be fixed. @whyrusleeping asked me to look over it; this is what I naturally do when I look over things. :) |
@dignifiedquire Should that be in the go-ipfs changelog? |
@RichardLitt I think so, as it changes the version that is being shipped with the binary (and it was a commit into this repo) |
webui update came after 0.3.11: https://github.com/ipfs/go-ipfs/commits/master?page=6. |
(I wasn't being asked, but just commented of imo on the consistency) |
😱 |
the webui update is technically part of 0.3.11 (its inside the tagged release) |
License: MIT Signed-off-by: Jeromy <[email protected]>
Also, there is http://manpages.ubuntu.com/manpages/lucid/man1/git-dch.1.html for auto-generating debian changelog, e.g. http://changelogs.debian.net/coreutils (using this would pick the "no strict capitalizing of the commit message" option). |
|
@RichardLitt @dignifiedquire do i have a LGTM ? |
LGTM |
(Except for the cap consistency issue I pointed out, LRGTM) |
LGTM |
finally add changelog for v0.3.11
License: MIT
Signed-off-by: Jeromy [email protected]